-
Notifications
You must be signed in to change notification settings - Fork 256
Bump versions #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions #690
Conversation
Bumps html5ever, markup5ever and xml5everf to 0.36.0. Bumps web_atoms to 0.1.4. Signed-off-by: Oriol Brufau <[email protected]>
c153bb1 to
be6c719
Compare
|
These have been published by @emilio: |
|
Even if phf had potentially breaking changes, I don't think that web_atoms had any, so I thought that a 0.1.4 was enough? |
|
I’m actually not entirely sure what is the correct answer. The question is what would happen if old html5ever release pulls the latest web_atom of which a breaking release phf is used underneath. The breaking release phf may cause trait conflicts or inconsistent hash being used. But since html5ever itself does not depend on phf directly. It may be fine? 🤷♂️ |
|
No problem from my side if you want to bump to 0.2.0 |
|
Yes, we'll need to yank and publish 0.2.0 instead. |
|
I can confirm that the Blitz build does actually break if I run |
Bumps html5ever, markup5ever and xml5everf to 0.36.0.
Bumps web_atoms to 0.1.4.